Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kotlin build #6478

Closed
wants to merge 1 commit into from
Closed

fix kotlin build #6478

wants to merge 1 commit into from

Conversation

beyang
Copy link
Member

@beyang beyang commented Dec 27, 2024

Breaking as of 30145b9

Test plan

Run build

@beyang beyang requested review from abeatrix, a team and dominiccooney December 27, 2024 23:59
@beyang beyang enabled auto-merge (squash) December 28, 2024 00:00
@beyang beyang disabled auto-merge December 28, 2024 00:05
@beyang beyang enabled auto-merge (squash) December 28, 2024 00:07
@beyang beyang disabled auto-merge December 28, 2024 00:07
@beyang beyang enabled auto-merge (squash) December 28, 2024 00:07
@pkukielka
Copy link
Contributor

Alternative fix: #6490
I also did some digging to check why it is failing in the first place, but with no big success.

@beyang
Copy link
Member Author

beyang commented Dec 30, 2024

Closing in favor of #6490

@beyang beyang closed this Dec 30, 2024
auto-merge was automatically disabled December 30, 2024 19:08

Pull request was closed

@beyang beyang deleted the bl/fix-kotlin branch December 30, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeatrix abeatrix abeatrix approved these changes

@dominiccooney dominiccooney Awaiting requested review from dominiccooney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beyang @pkukielka @abeatrix